[Dazuko-devel] Patch 4/5

[Lino Sanfilippo]

This patch fixes a missing cleanup in cases where an error occurs
after an event has already been assigned to a group.
Before an event has not been put back to the "todo" list properly
(the list_del() for the working list was missing) and also was not
put back in cases of error in dazukofs_group_read().

There is still something missing:
If a filedescriptor has already been opened for an event, it has to
be closed before it is put back to the "working list".
I will send a fix for this issue with another patch.


GeschÀftsfÌhrender Gesellschafter: Tjark Auerbach
Sitz der Gesellschaft: Tettnang
Handelsregister: Amtsgericht Ulm, HRB 630992
ALLGEMEINE GESCHÄFTSBEDINGUNGEN
Es gelten unsere Allgemeinen GeschÀftsbedingungen
(AGB). Sie finden sie in der jeweils gÃŒltigen Fassung
im Internet unter http://www.avira.de/agb
***************************************************

[John Ogness]

Post by Lino Sanfilippo
This patch fixes a missing cleanup in cases where an error occurs
after an event has already been assigned to a group. Before an
event has not been put back to the "todo" list properly (the
list_del() for the working list was missing) and also was not put
back in cases of error in dazukofs_group_read().
If a filedescriptor has already been opened for an event, it has to
be closed before it is put back to the "working list". I will send
a fix for this issue with another patch.

Thank you for pointing this out. The latest version (3.1.4-rc1) fixes
this issue and also handles closing the file descriptor. I chose not
to use your implementation because I felt it made the group use_count
handling too complicated.

John Ogness

[Lino Sanfilippo]

Post by John Ogness

Post by Lino Sanfilippo
This patch fixes a missing cleanup in cases where an error occurs
after an event has already been assigned to a group. Before an
event has not been put back to the "todo" list properly (the
list_del() for the working list was missing) and also was not put
back in cases of error in dazukofs_group_read().

Thank you for pointing this out. The latest version (3.1.4-rc1) fixes
this issue

The issue is still there. Have a look at claim_event() where we do:
- remove item from todo list
- put item on working list

If something fails afterwards we call unclaim_event() and only do:
- put item back on todo list

Removing the item from the working list in unclaim_event() is still
missing...

Regards,
Lino



Geschäftsführender Gesellschafter: Tjark Auerbach
Sitz der Gesellschaft: Tettnang
Handelsregister: Amtsgericht Ulm, HRB 630992
ALLGEMEINE GESCHÄFTSBEDINGUNGEN
Es gelten unsere Allgemeinen Geschäftsbedingungen
(AGB). Sie finden sie in der jeweils gültigen Fassung
im Internet unter http://www.avira.com/de/standard-terms-conditions-business-de
***************************************************